Feature/refactoring #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: dist/exceptionless.js.map dist/exceptionless.min.js.map dist/exceptionless.node.js.map
Conflicts: dist/exceptionless.js.map dist/exceptionless.min.js.map dist/exceptionless.node.js.map package.json src/EventBuilder.ts src/Utils-spec.ts src/Utils.ts src/plugins/default/ConfigurationDefaultsPlugin.ts src/plugins/default/EnvironmentInfoPlugin.ts src/plugins/default/ModuleInfoPlugin.ts src/plugins/default/RequestInfoPlugin.ts src/services/DefaultModuleCollector.ts src/services/DefaultRequestInfoCollector.ts src/services/NodeRequestInfoCollector.ts src/submission/DefaultSubmissionClient.ts
Conflicts: gulpfile.js
niemyjski
added a commit
that referenced
this pull request
Nov 24, 2015
Improvements to unit tests and formatting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does three things:
Prohibit any unused imports. This makes it easier to identify the actual dependencies of a module. Currently, we're using all classes ourselves, why everything is being exported automatically. As from now, any additional components must be explicitly re-exported by the root component:
Add a manual gulp task
gulp formatthat uses thetypescript-formatter. It uses our linter settings and the typescript-integrated code formatter to beautify all TS files. Should be executed from time to time in order to make merging easier.Tried to improve performance of non-build-tasks by moving some imports closer to their usage. We don't need to load all dependencies for all tasks.